Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sync.ts with additionalInformation as fallback #2176

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Update sync.ts with additionalInformation as fallback #2176

merged 6 commits into from
Jan 9, 2024

Conversation

wokkieman
Copy link
Contributor

added the additionalInformation as fallback for debtor and creditor

@wokkieman
Update sync.ts
7e1a200 
added the additionalInformation as fallback for debtor and creditor
@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e4905c3
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/659a5ed6d979360009740c44
😎 Deploy Preview https://deploy-preview-2176.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.43 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 112.27 kB 0%
static/js/reports.chunk.js 77.81 kB 0%
static/js/narrow-components.chunk.js 42.42 kB 0%
static/js/553.chunk.js 13.14 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.45 kB 0%

@MatissJanis
Copy link
Member

👋 Would you mind taking a look at the failing CI job?

Also: could you please provide an example JSON with the additionalInformation field being used. So we could double-check and perhaps test things.

Thanks!

@wokkieman
Copy link
Contributor Author

wokkieman commented Jan 7, 2024 •
edited
Loading

release notes added. Should all complete now

Example JSON

{
    "transactions": {
        "booked": [
            {
                "transactionId": "p3ZR5B3dlXc92gsc7XS2oSmAJz8HMiyxRXoEbhQ3bAy67Jl4vUCGlVmGvkSiH3_tJ_rFqSZbsoM",
                "entryReference": "RÄNTA 2023",
                "bookingDate": "2023-12-29",
                "valueDate": "2023-12-31",
                "transactionAmount": {
                    "amount": "10.56",
                    "currency": "SEK"
                },
                "additionalInformation": "RÄNTA",
                "proprietaryBankTransactionCode": "Other",
                "internalTransactionId": "e404da28161ce3efcf989e3bf9b15d51"
            },
			{
                "transactionId": "eGjtKt3bbt5nKQWZnf_4Wivn36zNpSyZ1h0mCTH7sNAwQnWD5m5C61mGvkSiH3_tEpgu5Yp5cGc",
                "entryReference": "5490920004",
                "bookingDate": "2023-12-27",
                "valueDate": "2023-12-23",
                "transactionAmount": {
                    "amount": "500.00",
                    "currency": "SEK"
                },
                "additionalInformation": "MORTGAGE",
                "proprietaryBankTransactionCode": "Transfer",
                "internalTransactionId": "16c698876be4a5535658fb1cb26605e6"
            },
			{
                "transactionId": "qwKvZYKfcvnI2eJpseTEcKQxeLrt8yIxPeipgKkQJcRG9Z93O3IOgRmW8fNiyFbuBu_LzGhFZ7o",
                "entryReference": "5485627087",
                "bookingDate": "2023-12-27",
                "valueDate": "2023-12-23",
                "transactionAmount": {
                    "amount": "57.00",
                    "currency": "SEK"
                },
                "additionalInformation": "KAPPAHL",
                "proprietaryBankTransactionCode": "Card purchase",
                "internalTransactionId": "08a91ea8086a69732371e181e187e30f"
            }
        ],
        "pending": []
    }
}

@MatissJanis
Copy link
Member

Perfect. For my banks additionalInformation contains the transaction id, not payee. But my banks (and I suppose others) return the debtor/creditor in other fields, so the new logic you created here won't apply.

I think it makes sense to add this as a final fallback in case no payees are found elsewhere.

@MatissJanis MatissJanis merged commit 97a4296 into actualbudget:master Jan 9, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 9, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
@wokkieman
Update sync.ts with additionalInformation as fallback (actualbudget#2176
8a0d210 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatissJanis MatissJanis MatissJanis approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wokkieman @MatissJanis